Problem with cond_put_corrupt_token test

[Tobias Schlitt]

Hi John,

On 11/08/2008 07:23 PM Joe Orton wrote:
> On Sat, Nov 08, 2008 at 06:25:26PM +0100, Tobias Schlitt wrote:
>> I examined the If header, which looks like this:
>>
>> If: (<opaquelocktoken:bed586e3-1876-3f16-b0c9-bccbd0c53947x>) (Not
>> <DAV:no-lock>)
>>
>> The first condition is the correct lock token, appended by an 'x' and
>> therefore a broken lock token. However, the second condition is negated,
>> therefore the condition list is overall evaluated to TRUE.

> I think you have this part wrong - it's a logical AND not a logical OR:
> 
> http://tools.ietf.org/html/rfc4918#section-10.4.3 para 2:
> 
>    Each List production describes a series of conditions.  The whole
>    list evaluates to true if and only if each condition evaluates to
>    true (that is, the list represents a logical conjunction of
>    Conditions).

I don't think so. The "List" in this part (note the uppercase 'L') is
defined by the BNF as:

List = "(" 1*Condition ")"

A bit later in 10.4.3 (para 3) it says:

   Each No-tag-list and Tagged-list production may contain one or more
   Lists.  They evaluate to true if and only if any of the contained
   lists evaluates to true (that is, if there's more than one List, that
   List sequence represents a logical disjunction of the Lists).

So the If header in the example is to be interpreted as:

<opaquelocktoken:bed586e3-1876-3f16-b0c9-bccbd0c53947x>
OR
Not <DAV:no-lock>

However, John already redirected me to the correct point, I think.

Thanks for your reply anyway,
Toby
-- 
Mit freundlichen Grüßen / Med vennlig hilsen / With kind regards

Tobias Schlitt (GPG: 0xC462BC14) eZ Components Developer

ts at ez.no | eZ Systems AS | ez.no

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 260 bytes
Desc: OpenPGP digital signature
Url : http://lists.manyfish.co.uk/pipermail/litmus/attachments/20081108/50c77971/attachment-0006.bin