Using PUT without a content-length

Julien Reichel Julien.Reichel at spinetix.com
Mon Jul 28 08:32:20 EDT 2008


Hi,
> 1) ne_request.h needs updating for the new interface of 
> passing length == -1 to ne_set_request_body_provider().
Done.
> 
> 2) sending chunks should really be done using writev(), so a 
> new method would need to be exposed via ne_socket.* for that.
Done. Not so sure it the nicest as possible (I don't like the two
mallocs, but did not come up with a better idea).
I did not implemented the writev for SSL connection, so there is a
fallback using the send function if the writev is not implemented.

> 
> 3) in the status handling, sr.total should be set to -1 to 
> indicate "unknown length", otherwise correct
Done
> 
> 4) code style nits, no // comments, follow neon style 
> generally with e.g. "if (foo)" not "if ( foo )" etc ;)
Hopefully done :-)

> Would you be willing to work on an updated patch for this 
> addressing some of these issues?
Hopefully done with the attached patch.

Julien

Visit http://www.spinetix.com/ for more information 

> 
> Regards, Joe
> 
> _______________________________________________
> neon mailing list
> neon at lists.manyfish.co.uk
> http://lists.manyfish.co.uk/mailman/listinfo/neon
> 


More information about the neon mailing list