[neon] NTLM
Joe Orton
joe at manyfish.co.uk
Fri Mar 20 11:50:27 EDT 2009
On Fri, Mar 20, 2009 at 11:33:23AM +0100, Kai Sommerfeld wrote:
> I picked up the donation from Daniel and adapted the code to fit into
> neon. Please find attached the diffs for neon 0.28.4. The feature can be
> activated by defining HAVE_NTLM. I have tested the implementation on
> Windows (XP), Solaris x86, Linux, Mac OS X.
>
> Please let me know what you think about this stuff. ;-)
Thanks for picking that up!
1) the void * -> NTLMContext conversion stuff is a bit weird; do:
typeded struct ne_ntlm_context_s ne_ntlm_context;
in the header and then use "ne_ntlm_context *" not void * in all the
interfaces, and declare the struct in the C file.
2) converting to neon standard indenting/code format would be good
3) needs some kind of mutual exclusion with HAVE_SSPI, right?
4) this does need the AUTH_FLAG_CONN_AUTH flag I think.
Do you want commit access to check this in?
Regards, Joe
More information about the neon
mailing list