FW: FW: SlikSVN 1.6.6 64-bit stalls on some operations

[Bert Huijben]

> -----Original Message-----
> From: Joe Orton [mailto:joe at manyfish.co.uk]
> Sent: vrijdag 8 januari 2010 12:51
> To: bert at vmoo.com
> Cc: neon at lists.manyfish.co.uk
> Subject: Re: FW: FW: SlikSVN 1.6.6 64-bit stalls on some operations
> 
> On Tue, Jan 05, 2010 at 06:13:16PM +0100, bert at vmoo.com wrote:
> > It looks like I can reproduce this issue when using SvnBridge as
> > installed by codeplex.
> >
> > E.g.
> > svn ls https://svnbridge.svn.codeplex.com/svn/ stalls after all the
> > output is done.
> 
> Thanks for reporting this.  The server is apparently ignoring the SSL
> close_notify alert and waiting for further I/O; that is a server bug
> which should be reported to the server admin.
> 
> Could you try this to see whether it makes any difference (or even
> compiles) on Windows?
> 
> --- src/ne_socket.c	(revision 1769)
> +++ src/ne_socket.c	(working copy)
> @@ -1899,6 +1899,11 @@
>      if (sock->ssl) {
>          /* Correct SSL shutdown procedure: call once... */
>          if (SSL_shutdown(sock->ssl) == 0) {
> +#if !defined(SHUT_WR) && defined(SD_SEND)
> +#define SHUT_WR SD_SEND
> +#endif
> +            shutdown(sock->fd, SHUT_WR);
> +            NE_DEBUG(NE_DBG_SSL, "ssl: Waiting for close_notify from
> peer.\n");
>              /* close_notify sent but not received; wait for peer to
>               * send close_notify... */
>              SSL_shutdown(sock->ssl);

This snippet compiles for me and fixes the noted issue. (It really needs the #define for me). 

But looking at the openssl documentation of SSL_shutdown(), I don't know if you can use both shutdown and SSL_shutdown safely in this snippet.
(SSL sometimes needs communication in two directions, just to keep the connection working).

Looking at the svn changelog, I see you already fixed this :)

Thanks,
	Bert