[PATCH] Fix Windows build with Expat 2.0

Bert Huijben bert at qqmail.nl
Tue Mar 15 10:04:29 EDT 2011



> -----Original Message-----
> From: Ivan Zhakov [mailto:ivan at visualsvn.com]
> Sent: dinsdag 15 maart 2011 14:53
> To: Bert Huijben
> Cc: neon at lists.manyfish.co.uk; jorton at redhat.com
> Subject: Re: [PATCH] Fix Windows build with Expat 2.0
> 
> On Tue, Mar 15, 2011 at 16:50, Bert Huijben <bert at qqmail.nl> wrote:
> >> -----Original Message-----
> >> From: neon-bounces at lists.manyfish.co.uk [mailto:neon-
> >> bounces at lists.manyfish.co.uk] On Behalf Of Ivan Zhakov
> >> Sent: dinsdag 15 maart 2011 9:37
> >> To: neon at lists.manyfish.co.uk; jorton at redhat.com
> >> Subject: Re: [PATCH] Fix Windows build with Expat 2.0
> >>
> >> On Tue, Mar 15, 2011 at 11:35, Ivan Zhakov <ivan at visualsvn.com> wrote:
> >> > Hi Joe,
> >> >
> >> > Please find attached small patch for Neon to fix building with Expat
> >> > 2.0 on Windows.
> >> >
> >> Sorry, I meant Expat 1.95.7.
> >
> > You should only add this define if you want to statically compile to expat.
> > NOT if you want to use the one in libaprutil-1.dll, like we used to do in
> Subversion before the last apr-util release.
> >
> apr-util always link Expat statically as far I know.

Maybe it does now, but it didn't do that before.

Like I said on another thread somewhere (probably dev at subversion.a.o): The real fix should be in apr-util, which added a regression on upgrading Expat.

	Bert




More information about the neon mailing list